Skip to content

frontend: SettingsCluster stories for cluster settings states#4707

Open
greedy-wudpeckr wants to merge 1 commit intokubernetes-sigs:mainfrom
greedy-wudpeckr:fix-c-settings
Open

frontend: SettingsCluster stories for cluster settings states#4707
greedy-wudpeckr wants to merge 1 commit intokubernetes-sigs:mainfrom
greedy-wudpeckr:fix-c-settings

Conversation

@greedy-wudpeckr
Copy link
Contributor

@greedy-wudpeckr greedy-wudpeckr commented Feb 14, 2026

Summary

This PR adds comprehensive Storybook coverage for the SettingsCluster, increasing test coverage from 0% to full visual documentation across all component states including cluster settings form, save operations, error handling, and validation scenarios.

Related Issue

Fixes #4682

Steps to Test

  • npm run frontend:storybook
  • Go to Settings > SettingsCluster in the sidebar
  • Test each story

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: greedy-wudpeckr
Once this PR has been reviewed and has the lgtm label, please assign yolossn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2026
@illume illume requested a review from Copilot February 14, 2026 18:22
Copilot AI reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive Storybook stories for the SettingsCluster component, fulfilling the requirements from issue #4682 to increase test coverage from 0% to full visual documentation. The stories demonstrate the cluster settings form across various states including form interactions, data persistence, error handling, and validation scenarios.

Changes:

  • Created SettingsCluster.stories.tsx with 11 story variants covering all major component states
  • Implemented a clean localStorage setup pattern using a helper function
  • Configured comprehensive mock Redux store to support all component dependencies
  • Added clear JSDoc documentation for each story explaining its purpose

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ashu8912 ashu8912 Awaiting requested review from ashu8912

@skoeva skoeva Awaiting requested review from skoeva

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

2 participants

@greedy-wudpeckr @k8s-ci-robot